Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove monkey patch hotfix for tinyrpc session IF upstream PR gets merged #354

Closed
konradkonrad opened this issue Jan 27, 2017 · 1 comment
Closed

Remove monkey patch hotfix for tinyrpc session IF upstream PR gets merged #354

konradkonrad opened this issue Jan 27, 2017 · 1 comment

Comments

@konradkonrad
Copy link
Contributor

Due to mbr/tinyrpc#26 our rpc client (pyethapp.rpc_client.JSONRPCClient) was prone to exhausting client ports.

I have created a PR against the upstream (tinyrpc) in order to address this. For the meantime, I have created a monkey patch (#350) to work around this.

Once the upstream PR is merged, or a similar patch is applied to pyethapp's JSONRPCClient, we should get rid of the monkey patching.
@konradkonrad konradkonrad mentioned this issue Jan 27, 2017
Merged
@LefterisJP
Copy link
Contributor

This issue is closed by commit: b771fc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LefterisJP @konradkonrad