-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Transpose and PermuteDimsArray #5
Comments
Corresponding discussion about tl;dr is that people find it weird that a constructor not return something of its own type, but |
That pretty much sums it up. It's also good to keep wrapping the type with the dimensional type on the outside for any other methods people want to put on the array type and for dispatch. How do you compare the two approaches after playing with the implementation in NamedPlus? |
Sorry I never replied. I think my answer is that it seems possible to make quite a long list of wrappers around your type work transparently, but it may be more hassle than it’s worth! My current attempt is AxisRanges.jl, which only tries to commute with NamedDims, which is much easier. |
Yeah wrappers are a no go. I decided DimensionalArrays are "dominant" types and just always re-wrap things, which is much less work. |
solutions:
Transpose(a::AbstractDimensionalArray)
that rewraps the Transpose in the dim array, as with SubArray in view.As discussed in
JuliaCollections/AxisArraysFuture#1
The text was updated successfully, but these errors were encountered: