Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import simple convex stl file #4829

Closed
mkeilman opened this issue Sep 12, 2022 · 5 comments
Closed

Import simple convex stl file #4829

mkeilman opened this issue Sep 12, 2022 · 5 comments
Assignees
Labels
Milestone

Comments

@mkeilman
Copy link
Contributor

mkeilman commented Sep 12, 2022

Build the basic import mechanism around a simple file such as
cube_1_mm.stl.txt

@mkeilman mkeilman added this to the mpmd milestone Sep 12, 2022
@mkeilman mkeilman mentioned this issue Sep 12, 2022
4 tasks
@mkeilman
Copy link
Contributor Author

Quick ping @Benbenbenin0 - lmk when you have started on this and if you have any questions. Incidentally I suggest writing a test (see #4849) for this in parallel, since the GUI part is a bit more involved.

@Benbenbenin0
Copy link
Contributor

Quick ping @Benbenbenin0 - lmk when you have started on this and if you have any questions. Incidentally I suggest writing a test (see #4849) for this in parallel, since the GUI part is a bit more involved.

Besides making edits to a previous PR this is my current issue I'm working on. I've familiarized a bit with the GUI code and am looking into writing the convexity test.

@mkeilman
Copy link
Contributor Author

Quick ping @Benbenbenin0 - lmk when you have started on this and if you have any questions. Incidentally I suggest writing a test (see #4849) for this in parallel, since the GUI part is a bit more involved.

Besides making edits to a previous PR this is my current issue I'm working on. I've familiarized a bit with the GUI code and am looking into writing the convexity test.

If you mean you are writing your own code to test for the convexity of a polyhedron, that should not be necessary. The trimesh library does that work, which our tests should invoke.

@Benbenbenin0
Copy link
Contributor

Benbenbenin0 commented Sep 21, 2022

Right I realized I'm just using the trimesh repo after making the comment. I also grabbed the image from the branch you made (thank you), I have a branch for issue #4848.

EDIT: Lost the remote version of my branch somehow, moving to the one you made.

@robnagler robnagler changed the title Import simple convex stl file Import simple convex stl file Oct 11, 2022
@Benbenbenin0
Copy link
Contributor

Issue merged into #4848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants