Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practice when root == parent? #1098

Closed
m-mohr opened this issue Apr 23, 2021 · 4 comments · Fixed by #1101
Closed

Best practice when root == parent? #1098

m-mohr opened this issue Apr 23, 2021 · 4 comments · Fixed by #1101
Assignees
Labels
Milestone

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Apr 23, 2021

When doing some examples, I was wondering what the best practice is for STAC entities for which the parent and the root catalog are the same (i.e. childs of the root). Should we have links with:

  1. parent and root defined?
  2. only root defined?
@m-mohr m-mohr added this to the 1.0.0-rc.3 milestone Apr 23, 2021
@cholmes
Copy link
Contributor

cholmes commented Apr 23, 2021

I'd say define both. Seems easier for clients to just look at one field.

@matthewhanson
Copy link
Collaborator

+1 on both

@cholmes cholmes self-assigned this Apr 23, 2021
@cholmes
Copy link
Contributor

cholmes commented Apr 23, 2021

I'll do a PR to update the examples to always have both.

Not sure if we need to actually say this anywhere? I lean towards no, but happy to add something in.

@m-mohr
Copy link
Collaborator Author

m-mohr commented Apr 23, 2021

I would mention it somewhere, at least it was something I was not sure about. Could be BP though.

@m-mohr m-mohr linked a pull request Apr 26, 2021 that will close this issue
3 tasks
@m-mohr m-mohr closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants