Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create exceptions just for logging #1440

Closed
paulomorgado opened this issue Dec 5, 2023 · 2 comments
Closed

Do not create exceptions just for logging #1440

paulomorgado opened this issue Dec 5, 2023 · 2 comments
Assignees
@lukebakken
Labels
bug
Milestone
7.0.0

Comments

@paulomorgado
Copy link
Contributor

Describe the bug

Some exceptions are being created just for logging here and here

Reproduction steps

Just log the error. No need for an exception.

But, if it's really needed, don't use System.Exception: see #1439

Expected behavior

No exception is created just for logging.

Additional context

No response
@lukebakken lukebakken self-assigned this Dec 5, 2023
@lukebakken lukebakken added this to the 7.0.0 milestone Dec 5, 2023
@lukebakken
Copy link
Contributor

lukebakken commented Dec 5, 2023 •
edited
Loading

Thank you @paulomorgado!

169a6d1#r134239817

@lukebakken
Copy link
Contributor

I just did a search for new.*Exception within the main branch and it appears that this has been resolved over the course of working on version 7.

@lukebakken lukebakken mentioned this issue May 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
bug
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@paulomorgado @lukebakken