Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to use a ulong as a header value #1298

Closed
thepunkoff opened this issue Feb 14, 2023 · 5 comments
Closed

Impossible to use a ulong as a header value #1298

thepunkoff opened this issue Feb 14, 2023 · 5 comments
Milestone
6.5.0

Comments

@thepunkoff
Copy link

thepunkoff commented Feb 14, 2023 •
edited
Loading

Is there any particular reason why ulongs are forbidden as header values (source)? Shouldn't we support all primitive types for convenience?
@michaelklishin
Copy link
Member

No reason other than: many other clients won't be able to support unsigned numerical types. But we can add support for them in this client.

@thepunkoff
Copy link
Author

thepunkoff commented Feb 14, 2023 •
edited
Loading

Yeah, but uints and ushorts are already supported right now, even if other clients don't expect them. That's why I'm asking. It would be great to have them all supported!

I could send a nice little PR in my free time

@michaelklishin
Copy link
Member

By all means, please feel free to look into it and submit a PR. Thank you!

@thepunkoff
Copy link
Author

thepunkoff commented Feb 14, 2023 •
edited
Loading

I've posted a PR (#1299)!

@Zerpet Zerpet linked a pull request Feb 15, 2023 that will close this issue
Add support for ulong header values #1299
Closed
11 tasks
@Zerpet Zerpet added this to the 6.5.0 milestone Feb 15, 2023
@thepunkoff
Copy link
Author

Closing as "won't do". Details: #1299

@thepunkoff thepunkoff closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.0
Development

Successfully merging a pull request may close this issue.

Add support for ulong header values thepunkoff/rabbitmq-dotnet-client
3 participants
@michaelklishin @Zerpet @thepunkoff