Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testnet): introduce new API version for testnet to handle Trie error from 2412? #437

Open
peterwht opened this issue Jan 20, 2025 · 1 comment
Labels
question Further information is requested

Comments

@peterwht
Copy link
Collaborator

#425 (comment)

In the 2412 uplift, a new variant in DispatchError was introduced: Trie. If we want to maintain backwards compatibly for testnet, we would have to create a new API version for the DispatchError that uses Trie, and then a mapping to the UnknownVariant to ensure things stay backwards compatible for the old API version.

@peterwht peterwht added the question Further information is requested label Jan 20, 2025
@peterwht peterwht changed the title introduce new API version for testnet to handle Trie error from 2412? feat(testnet): introduce new API version for testnet to handle Trie error from 2412? Jan 20, 2025
@Daanvdplas
Copy link
Collaborator

I think we should value this change in the SDK and take it as an exercise for how to handle these breaking changes for contracts deployed. We don't know how often this might happen so we want to extract all the information from it that is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants