From 0fa3269ed9bcba2a7955b8e56a45f9f20be7265e Mon Sep 17 00:00:00 2001 From: Hadley Wickham Date: Fri, 10 Jan 2025 16:57:10 -0600 Subject: [PATCH] Update CRAN comments --- cran-comments.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index f36f30724..847a30bb0 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -5,8 +5,8 @@ There is one check note in this version: File ‘testthat/libs/testthat.so’: Found non-API calls to R: ‘SET_BODY’, ‘SET_CLOENV’, ‘SET_FORMALS’ -The plan is to remove these calls in the next release, but I wanted to deprecated the problematic functions `with_mock()` and `local_mock()` first so that users get a little warning. +The plan is to remove these calls in the next minor release. I have now informed the majority of users that these functions are going away. ## revdepcheck results -We checked all reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. There were a few failures due to some new strictness and use of internal failures. I've tracked fixes for them at https://github.com/r-lib/testthat/issues/2021. +I did not check revdeps since the fixes are minor and should only decrease the number of errors.