Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in example reprex in CONTRIBUTING #1625

Closed
debruine opened this issue Apr 14, 2021 · 1 comment
Closed

Error in example reprex in CONTRIBUTING #1625

debruine opened this issue Apr 14, 2021 · 1 comment

Comments

@debruine
Copy link

On the CONTRIBUTING page (also the link when you open your first issue), the code for the reprex contains:

tmp <- file.path(tempdir(), "test")
usethis::create_package(tmp, open)

open is a function and causes the error

Error: fields must be a list, not 'function'.

I'm not sure if open should be removed, set to TRUE, or set to FALSE (I'm having trouble with both T and F when trying to make a reprex).

@maelle
Copy link
Collaborator

maelle commented Apr 15, 2021

Thanks for reporting the inconsistency!

In #1620 and #1471 the argument open was removed. As reprexes are run in non interactive sessions, the default would be it's not opened when running reprex. Now, when working on the code for the reprex, you probably will run the code line by line and not with reprex?

Sometimes people go a step further and put a reprex repo on GitHub with the built website in there e.g. #992 (comment), I wonder whether this should be documented in the contributing guide.

@hadley hadley closed this as completed in 29a1b3b Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants