Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messy testthat output due to 3e #965

Closed
AshesITR opened this issue Mar 21, 2022 · 1 comment · Fixed by #967
Closed

Messy testthat output due to 3e #965

AshesITR opened this issue Mar 21, 2022 · 1 comment · Fixed by #967

Comments

@AshesITR
Copy link
Collaborator

From ?testthat::expect_warning:

In the 3rd edition, these functions match (at most) a single condition. All additional and non-matching (if regexp or class are used) conditions will bubble up outside the expectation. If these additional conditions are important you'll need to catch them with additional expect_message()/expect_warning() calls; if they're unimportant you can ignore with suppressMessages()/suppressWarnings().

This causes a lot of noise in the output of devtools::test() on master atm.

@AshesITR
Copy link
Collaborator Author

Here is what devtools::test() interactively produces:

  • test-backport_linter.R:9 Warning bubbles
  • test-cache.R produces output
  • test-cache.R:91 Two warnings bubble
  • test-ci.R:39 Deprecation warning for with_mock()
  • test-ci.R:52 Deprecation warning for with_mock()
  • test-dir_linters.R produces output
  • test-expect_lint.R produces output
  • test-expect_lint.R:59 calls RStudio API
  • test-knitr_formats.R produces output
  • test-lint_package.R produces output
  • test-methods.R:117 Deprecation warning for with_mock()
  • test-object_usage_linter.R produces output
  • test-rstudio_markers.R:97 Deprecation warning for with_mock()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant