Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser() and other debugging calls as default undesirable functions #876

Closed
MichaelChirico opened this issue Oct 12, 2021 · 1 comment · Fixed by #877
Closed

Add browser() and other debugging calls as default undesirable functions #876

MichaelChirico opened this issue Oct 12, 2021 · 1 comment · Fixed by #877

Comments

@MichaelChirico
Copy link
Collaborator

Leaving calls like browser() in the code after the bug is fixed is a common mistake; most "finished" code (especially in packages) shouldn't need to call this.

I believe the same goes for debug(), undebug(), trace(), untrace(), and debugcall().

I think it would make sense for these to be in the default set of undesirable functions for undesirable_function_linter.

Any second thoughts?

@AshesITR
Copy link
Collaborator

I agree, add debugonce() to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants