Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching and # nolint #68

Closed
krlmlr opened this issue Mar 23, 2015 · 2 comments · Fixed by #69
Closed

Caching and # nolint #68

krlmlr opened this issue Mar 23, 2015 · 2 comments · Fixed by #69

Comments

@krlmlr
Copy link
Member

krlmlr commented Mar 23, 2015

The # nolint comments don't seem to work properly with caching. They are respected only on first execution (presumably, when the cache is dirty) -- from the second execution onwards, errors are reported.

Try

lintr::lint_package(".", cache = TRUE)

for my package.

@jimhester
Copy link
Member

Probably all that needs to change is changing this return to return(exclude(lints, ...))

https://github.com/jimhester/lintr/blob/9b5a6b275898f8a852da8c946ac9ca70cf81cd5c/R/lint.R#L45

@krlmlr
Copy link
Member Author

krlmlr commented Mar 24, 2015

Works for me: all existing tests pass, ignores are respected with caching. I'll submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants