Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter names are hard-coded #664

Closed
AshesITR opened this issue Dec 4, 2020 · 1 comment · Fixed by #673
Closed

linter names are hard-coded #664

AshesITR opened this issue Dec 4, 2020 · 1 comment · Fixed by #673

Comments

@AshesITR
Copy link
Collaborator

AshesITR commented Dec 4, 2020

Actual:

as.data.frame(lintr::lint("A = 42\n", linters = list(lala = lintr::assignment_linter)))
>  filename line_number column_number  type                        message   line
>1   <text>           1             3 style Use <-, not =, for assignment. A = 42
>             linter
>1 assignment_linter

Expected:

as.data.frame(lintr::lint("A = 42\n", linters = list(lala = lintr::assignment_linter)))
>  filename line_number column_number  type                        message   line
>1   <text>           1             3 style Use <-, not =, for assignment. A = 42
>             linter
>1 lala
@AshesITR
Copy link
Collaborator Author

AshesITR commented Dec 4, 2020

This feature is particularly useful in combination with #660 because it allows for a straight-forward way to specify exclusions even for parameterised linters with multiple instances running, e.g. multiple unwanted_function_linters with different blacklists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant