Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive for yoda_test_linter in magrittr pipeline #1066

Closed
MichaelChirico opened this issue Apr 12, 2022 · 1 comment
Closed

False positive for yoda_test_linter in magrittr pipeline #1066

MichaelChirico opened this issue Apr 12, 2022 · 1 comment
Labels
false-positive code that shouldn't lint, but does
Milestone
3.0.0

Comments

@MichaelChirico
Copy link
Collaborator

MichaelChirico commented Apr 12, 2022 •
edited
Loading

A pattern seen a lot in formula.tools:

https://github.com/decisionpatterns/formula.tools/blob/45b6654e4d8570cbaf1e2fd527652471202d97ad/tests/testthat/test-lhs.r#L13

lhs( NA ~ . )   %>% expect_equal(NA)

IMO this is not the best way to write tests, but nevertheless we shouldn't trigger a lint with yoda_test_linter().
@MichaelChirico MichaelChirico added the false-positive code that shouldn't lint, but does label Apr 12, 2022
@MichaelChirico MichaelChirico mentioned this issue Apr 12, 2022
Merged
@MichaelChirico MichaelChirico added this to the 3.0.0 milestone Apr 12, 2022
@MichaelChirico
Copy link
Collaborator Author

closed by #1065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-positive code that shouldn't lint, but does
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@MichaelChirico