Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False-positive undesirable_function_linter for df$source <- 1 #1050

Closed
bersbersbers opened this issue Apr 4, 2022 · 3 comments · Fixed by #1112
Closed

False-positive undesirable_function_linter for df$source <- 1 #1050

bersbersbers opened this issue Apr 4, 2022 · 3 comments · Fixed by #1112

Comments

@bersbersbers
Copy link

image

I thought this had beed addressed in #556, but maybe not completely.

@AshesITR
Copy link
Collaborator

AshesITR commented Apr 4, 2022

Thanks for reporting!

That's due to the symbol_is_undesirable = TRUE default, I think. For a temporary fix, you can set that to FALSE.
Still, the logic used in object_name_linter() to skip $-expressions could be added to undesirable_function_linter() as well.

@bersbersbers
Copy link
Author

That's due to the symbol_is_undesirable = TRUE default, I think

Very vell possible. I am experimenting with linters_with_tags(tags = NULL) right now.

@MichaelChirico
Copy link
Collaborator

In that case, you can edit the default arguments like so:

linters_with_tags(NULL,
  undesirable_function_linter(symbol_is_undesirable=FALSE)
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants