Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conjunct_test_linter could work for assert_that() as well #1016

Closed
MichaelChirico opened this issue Mar 28, 2022 · 0 comments · Fixed by #1022
Closed

conjunct_test_linter could work for assert_that() as well #1016

MichaelChirico opened this issue Mar 28, 2022 · 0 comments · Fixed by #1022
Milestone
3.0.0

Comments

@MichaelChirico
Copy link
Collaborator

Follow-up to #1011

assertthat::assert_that(A && B), by the same reasoning as the other cases in conjunct_test_linter(), would be better as assertthat::assert_that(A, B).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

conjunct_test linter extended for assertthat usage r-lib/lintr
1 participant
@MichaelChirico