From 67576efb1a33196ce422f58cbf5a847beafaff54 Mon Sep 17 00:00:00 2001
From: Indrajeet Patil <patilindrajeet.science@gmail.com>
Date: Tue, 20 Dec 2022 19:31:21 +0100
Subject: [PATCH] Tests for multiple lints in `unnecessary_nested_if_linter()`
 (#1834)

---
 .../test-unnecessary_nested_if_linter.R       | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/tests/testthat/test-unnecessary_nested_if_linter.R b/tests/testthat/test-unnecessary_nested_if_linter.R
index ec111ddff..f5b87a68e 100644
--- a/tests/testthat/test-unnecessary_nested_if_linter.R
+++ b/tests/testthat/test-unnecessary_nested_if_linter.R
@@ -10,6 +10,17 @@ test_that("unnecessary_nested_if_linter skips allowed usages", {
     linter
   )
 
+  expect_lint(
+    trim_some("
+    for (x in 1:3) {
+      if (x && y) {
+        1L
+      }
+    }"),
+    NULL,
+    linter
+  )
+
   expect_lint(
     trim_some("
       if (x) {
@@ -212,4 +223,29 @@ test_that("unnecessary_nested_if_linter blocks disallowed usages", {
     lint_message,
     linter
   )
+
+  expect_lint(
+    trim_some("
+    for (x in 1:3) {
+      if (x) if (y) 1L
+    }"),
+    lint_message,
+    linter
+  )
+
+  expect_lint(
+    trim_some("
+      if (x) {
+        if (y) {
+          if (z) {
+            1L
+          }
+        }
+      }"),
+    list(
+      list(message = lint_message, line_number = 2L, column_number = 3L),
+      list(message = lint_message, line_number = 3L, column_number = 5L)
+    ),
+    linter
+  )
 })