dbAppendTable() no longer works with Id

[renkun-ken]

See #253

In previous releases, dbAppendTable(con, Id(schema = "foo", table = "bar"), data) works as documented at https://github.com/r-dbi/DBI/blob/main/R/Id.R#L16 but has stopped working since v1.1.2.

The check at

DBI/R/dbAppendTable_DBIConnection.R

Line 7 in 273d195

stopifnot(is.character(name), length(name) == 1)

ignores that name might be Id and sqlAppendTableTemplate would call dbQuoteIdentifier with the name anyway.

DBI/R/sqlAppendTableTemplate.R

Line 26 in 273d195

table <- dbQuoteIdentifier(con, table)

Does it make sense if we remove the check of name in sqlAppendTableTemplate or allow it to be Id?

[krlmlr]

Thanks, makes sense. We also need a test in DBItest.

[renkun-ken]

Do you prefer simply removing the check or allowing it to be Id in the check?

[krlmlr]

Should we check after calling dbQuoteIdentifier() ?

[renkun-ken]

Looks like dbQuoteIdentifier already does all necessary checks.

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.