Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byte check should be in analyzeFile #48

Closed
PipeItToDevNull opened this issue Jan 5, 2025 · 0 comments · Fixed by #50
Closed

Byte check should be in analyzeFile #48

PipeItToDevNull opened this issue Jan 5, 2025 · 0 comments · Fixed by #50
Labels
api enhancement New feature or request

Comments

@PipeItToDevNull
Copy link
Member

PipeItToDevNull commented Jan 5, 2025 •
edited
Loading

Move the byte check from handleAnalyzeDmp to analyzeFile

This would allow us to check that files in zips are also dmps before processing them, right now it just handles any file inside an archive.

Or just make it its own function, that would likely be better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move file header checking to a function and use it for single files a… r-Techsupport/WebDBG
1 participant
@PipeItToDevNull