Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

redux-async-connect no longer maintained. #440

Closed
thabti opened this issue Aug 8, 2016 · 8 comments
Closed

redux-async-connect no longer maintained. #440

thabti opened this issue Aug 8, 2016 · 8 comments

Comments

@thabti
Copy link
Contributor

thabti commented Aug 8, 2016

Seems like redux-async-connect is no longer maintained. There is a fork project which has better React 15 support:

https://github.com/makeomatic/redux-connect

@mmahalwy
Copy link
Contributor

mmahalwy commented Aug 8, 2016

@sabeurthabti i want to get rid of redux-async-connect and it's fork. This should be done in onEnter of router. Will get to this soon inshallah :)

@mmahalwy
Copy link
Contributor

mmahalwy commented Aug 8, 2016

Or next year
'under promise and over deliver'

@thabti
Copy link
Contributor Author

thabti commented Aug 9, 2016

@mmahalwy
Copy link
Contributor

@sabeurthabti yeah, i saw these packages, and they are good, but they wrap the component rather than on the route level. Difference: you cannot do things like redirect on server side with status codes since it has to walk down the routes to generate and find if they have async requirements.

@atalebagha
Copy link
Contributor

How about Redial? it looks promising?

@atalebagha
Copy link
Contributor

Sorry didn't notice @sabeurthabti's post

@mmahalwy
Copy link
Contributor

mmahalwy commented Sep 14, 2016

@atalebagha i think we should use the onEnter hook for the router since, from my personal experience, I have been burnt with libraries like async-redux or redial that end up not getting maintained. React-router is all over the place too, so I can see a point for why not to go that route (haha, no pun intended!)

@mmahalwy
Copy link
Contributor

I want to bump this up and revisit this. I think we could have a snappier experience than the one we currently have.

The problem:

  • Most users come to the homepage then navigate to the Surah they want.
  • We have SSR because of SEO. And are most valuable when Google scraps our Surah pages
  • That being said, when a user navigates from Home to Surah container, the page does nothing until all the data is loaded. This is by design that the same code is used for SSR and for client side routing due to asyncConnect. We should change that and have a faster/snappier experience for the user. We should get smart to wait to load the page for SSR but navigating to the page client side should show a loader or something.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants