Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented updated.filters feature is not implemented #1690

Closed
klr8 opened this issue Feb 14, 2023 · 1 comment · Fixed by #1695
Closed

Documented updated.filters feature is not implemented #1690

klr8 opened this issue Feb 14, 2023 · 1 comment · Fixed by #1695

Comments

@klr8
Copy link

klr8 commented Feb 14, 2023

Description of Problem / Feature Request

The "Updaters and Airgap" documentation mentions a "Filtering Updaters" feature:
https://github.com/quay/clair/blob/main/Documentation/concepts/updatersandairgap.md#filtering-updaters

This feature does not seem to be implemented.
The only related thing I could find in the source code is a RegexFilter function in the updaters module:
https://github.com/quay/claircore/blob/1405b573a27c08e12d974f0f2b7f4dcf1b149183/libvuln/driver/updaterset.go#L95

But that does not seem to be used by the rest of the code.

Note that the main "Config" documentation does not mention updaters.filters:
https://github.com/quay/clair/blob/main/Documentation/reference/config.md

Expected Outcome

As documented, have an ability to filter the enabled updaters. This can help in reducing the amount of vulnerabilities that need to be downloaded: e.g. we no longer have RHEL6 and don't want to download the large amount of vulnerabilities related to that RHEL distribution.

Actual Outcome

Updater filtering is not implemented.

Environment

  • Clair version/image: 4.6.0
@hdonnay
Copy link
Member

hdonnay commented Feb 15, 2023

Yeah this should be removed from the documentation, as it's not used and implemented as a filter on updater name, which is going to be much less useful with the new updater API, which allows for handling multiple files in a way that the current system doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants