From 673bd0fe32d5422e8eb3dff3716a2bfce81b891c Mon Sep 17 00:00:00 2001 From: Ales Raszka Date: Mon, 19 Oct 2020 19:19:10 +0200 Subject: [PATCH] Notifier: fix poller loop The return was in incorrect place and cause that only first updater was processed. Rest of updaters were skipped. Signed-off-by: Ales Raszka --- notifier/poller.go | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/notifier/poller.go b/notifier/poller.go index 90c372187b..0bdce01fed 100644 --- a/notifier/poller.go +++ b/notifier/poller.go @@ -117,12 +117,18 @@ func (p *Poller) onTick(ctx context.Context, c chan<- Event) { select { case c <- e: default: - log.Warn().Str("updater", e.updater).Str("UOID", e.uo.Ref.String()).Msg("could not deliver event to channel. backing off till next tick") + log.Warn(). + Str("updater", updater). + Str("UOID", latest.Ref.String()). + Msg("could not deliver event to channel. skipping updater now") } - return + continue } if err != nil { - log.Error().Err(err).Msg("received error getting receipt by UOID. backing off till next tick") + log.Error().Err(err). + Str("updater", updater). + Str("UOID", latest.Ref.String()). + Msg("received error getting receipt by UOID. backing off till next tick") return } }