Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show more auto collapses making copying hard #2044

Closed
maxandersen opened this issue Jul 12, 2024 · 3 comments · Fixed by quarkusio/quarkus#41959
Closed

show more auto collapses making copying hard #2044

maxandersen opened this issue Jul 12, 2024 · 3 comments · Fixed by quarkusio/quarkus#41959

Comments

@maxandersen
Copy link
Member

from zulip @galderz reported:
"I was trying to copy something that was shown in https://quarkus.io/guides/container-image after clicking on "Show more" and after selecting the text, the text section goes back to showing less. This is annoying since you can't see if the text is still selected...etc. Who takes care of this UI?"

I can reproduce it on osx firefox and chrome.

see recording

2024-07-12_08-29-28.mp4
@insectengine
Copy link
Collaborator

Ah ok, wasn't following.

This is the default action off the config table as created in adoc. The entire row is clickable to make the hide/show function (not just the "show more" link). There is the icon on the right for copying code, but apparently folks don't like/or notice it.

I still question the need for this content to even have a hide/show feature as the bulk of the content is very short.

I'll look into if we can reasonably modify the default.

@insectengine
Copy link
Collaborator

Worked with @ebullient to make a fix.

quarkusio/quarkus#41959

@galderz
Copy link
Member

galderz commented Jul 24, 2024

This is the default action off the config table as created in adoc. The entire row is clickable to make the hide/show function (not just the "show more" link). There is the icon on the right for copying code, but apparently folks don't like/or notice it.

Oh I didn't notice the copy icon, but that only copies the environment variable name? I was trying to copy the configuration option explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants