Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JDK immutable lists to reduce arity of List invokeInterface #42982

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Sep 3, 2024

This commit was cherry-picked from #42909.

CC @franz1981

@mkouba mkouba marked this pull request as ready for review September 3, 2024 08:12
Copy link

quarkus-bot bot commented Sep 3, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@mkouba
Copy link
Contributor Author

mkouba commented Sep 3, 2024

I will attach some benchmark numbers in the afternoon.

Copy link

quarkus-bot bot commented Sep 3, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit da7c0ad.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

⚙️ JVM Tests - JDK 21

📦 core/deployment

io.quarkus.deployment.dev.FileSystemWatcherTestCase.testFileSystemWatcher - History

  • expected: not <null> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: not <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:152)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertNotNull.failNull(AssertNotNull.java:49)
	at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:35)
	at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:30)
	at org.junit.jupiter.api.Assertions.assertNotNull(Assertions.java:304)
	at io.quarkus.deployment.dev.FileSystemWatcherTestCase.consumeEvents(FileSystemWatcherTestCase.java:169)

@mkouba mkouba added the area/qute The template engine label Sep 3, 2024
@mkouba
Copy link
Contributor Author

mkouba commented Sep 3, 2024

Here are the results (on a dedicated but rather slow box :-). What's interesting that it does not improve all benchmarks. However, I ran it several times and the improvement for Loop15/Loop50 was 7-9%/9-11%. So definitely 👍 from my POV.

RESULTS SUMMARY          |3.8.6                    |3.14.1                   |999-SNAPSHOT             
=========================|Score    |Error  |Diff   |Score    |Error  |Diff   |Score    |Error  |Diff   
-------------------------|-------------------------|-------------------------|-------------------------
HelloParser              |      664|     29|       |      664|     35|     0%|      656|     43|    -1%
HelloSimple              |    25628|   1083|       |    25154|   1116|    -2%|    25217|    497|     0%
IfComplex                |     5882|    303|       |     5778|    437|    -2%|     5653|    293|    -2%
IfSimple                 |     7855|    428|       |     7887|    495|     0%|     7956|    373|    +1%
IncludeSimple            |    21377|    703|       |    21011|    740|    -2%|    20826|    764|    -1%
JavaBeanValueResolver    |    31875|   1173|       |    31043|   1976|    -3%|    31572|   1481|    +2%
LetComplex               |     5949|    250|       |     5881|    154|    -1%|     5739|    260|    -2%
LetSimple                |    16523|    929|       |    16818|    666|    +2%|    16831|    734|     0%
Loop15                   |    33319|   1573|       |    34050|   1080|    +2%|    36397|   1983|    +7%
Loop50                   |    10375|    619|       |    10458|    445|    +1%|    11500|    585|   +10%
NameResolver             |    18514|    623|       |    18621|    592|    +1%|    18323|    783|    -2%
When                     |     9022|    471|       |     9122|    448|    +1%|     8764|    441|    -4%

qute-microbenchmarks

@mkouba mkouba merged commit 2539288 into quarkusio:main Sep 3, 2024
66 of 67 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 3, 2024
@mkouba mkouba mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants