Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Keycloak Dev Service for standalone Keycloak Admin Client extensions and OIDC Client Registration #44143

Closed
michalvavrik opened this issue Oct 28, 2024 · 2 comments · Fixed by #44389

Comments

@michalvavrik
Copy link
Member

michalvavrik commented Oct 28, 2024

Description

We now support starting Keycloak Dev Service for standalone OIDC Client #43609. I think we agreed to allow starting Keycloak Dev Service for standalone:

  • Keycloak Admin REST Client
  • Keycloak Admin RESTEasy Client
  • OIDC Client Registration

Implementation ideas

I am opening this for issue for myself, mostly to give anyone (like @sberyozkin ) chance to say we don't need this, because I might have misunderstood original discussion. I plan to work on this very soon.

Regarding actual implementation, what needs to be done is:

  • add dependency to Keycloak Dev Svc to these extensions
  • refactor Keycloak Dev Svc:
    • logic when the Dev Svc is disabled needs to be moved from this Dev Svc extension to individual extensions (like OIDC says when it needs Dev Svc, and OIDC Client says when it needs Dev Svc) so that we can extend this extension to support KC Admin client etc.
    • config properties preset by the Dev Svc for individual extensions (like OIDC auth server url, OIDC Client auth server URL and others) must also be somehow owned by individual extensions and not by the Dev Svc
Copy link

quarkus-bot bot commented Oct 28, 2024

/cc @geoand (devservices), @pedroigor (keycloak,oidc), @sberyozkin (keycloak,oidc), @stuartwdouglas (devservices)

@michalvavrik michalvavrik self-assigned this Oct 28, 2024
@sberyozkin
Copy link
Member

Thanks @michalvavrik, I'll get back to it asap, once we get the very important PR you did related to the ConfigMapping migration merged, cheers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants