Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ReactJS class should not be registered as a service #6

Open
stof opened this issue Aug 11, 2015 · 2 comments
Open

The ReactJS class should not be registered as a service #6

stof opened this issue Aug 11, 2015 · 2 comments

Comments

@stof
Copy link

stof commented Aug 11, 2015

This class is executing some JS code in its constructor. This makes the constructor very heavy, and you don't want this to be executed on each instantiation of Twig (which happens on each request in most Symfony projects).
It should be instantiated only when needed to render an element

@jibriss
Copy link

jibriss commented Aug 11, 2015

Maybe he should just stop depending on reactjs/react-php-v8js
All your issues are related to this class ^^

@stof
Copy link
Author

stof commented Aug 11, 2015

@jibriss they are indeed. And btw, the library is not really maintained.
the right solution would probably for @qpautrat to join the team maintaining the library to improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants