Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ./util/docker_build.sh should not require docker-machine #24273

Closed
2 tasks
puchupala opened this issue Aug 13, 2024 · 2 comments
Closed
2 tasks

[Bug] ./util/docker_build.sh should not require docker-machine #24273

puchupala opened this issue Aug 13, 2024 · 2 comments

Comments

@puchupala
Copy link

puchupala commented Aug 13, 2024

Describe the Bug

I used to be able to ./util/docker_build.sh on my Mac without having to install docker-machine. However, since #23988 make ./util/docker_build.sh call ./util/docker_cmd.sh, it is now also (seemingly unnecessary) require docker-machine as well.

I tried commenting out docker-machine checking code and ./util/docker_build.sh still ran and built my firmware just fine, suggesting that it's not necessary for building.

Keyboard Used

No response

Link to product page (if applicable)

No response

Operating System

MacOS

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

@tzarc
Copy link
Member

tzarc commented Aug 13, 2024

You'll find that the docker-machine check has been present for much longer than the PR you've quoted.

It's there to enable flashing -- historically we've had support requests as to why flashing doesn't work with docker builds, so I'd imagine this is why that check is present.

Feel free to raise a PR adding a new environment variable or similar mechanism to disable the check -- it'll need to stay on by default.

@puchupala
Copy link
Author

You'll find that the docker-machine check has been present for much longer than the PR you've quoted.

@tzarc My apologies. I was using ZSA's fork on firmware23 branch, which doesn't have docker-machine check in ./util/docker_build.sh.

Feel free to raise a PR adding a new environment variable or similar mechanism to disable the check -- it'll need to stay on by default.

I'll get to that. Thank you very much for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants