Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAGIC_TOGGLE_GUI missing from full list of keycodes #14957

Closed
blown-capacitance opened this issue Oct 26, 2021 · 2 comments · Fixed by #14959
Closed

MAGIC_TOGGLE_GUI missing from full list of keycodes #14957

blown-capacitance opened this issue Oct 26, 2021 · 2 comments · Fixed by #14959
Labels
help wanted question

Comments

@blown-capacitance
Copy link

Looks like when the change occurred to add MAGIC_TOGGLE_GUI the magic keycodes documentation was updated but not the full one.

docs/keycodes.md - doesn't have it

docs/keycodes_magic.md - does, the specific table row below:

MAGIC_TOGGLE_GUI GUI_TOG Toggles the status of the GUI keys
@filterpaper filterpaper mentioned this issue Oct 26, 2021
Merged
14 tasks
@filterpaper
Copy link
Contributor

@blown-capacitance Please help confirm that #14959 resolves this.

@blown-capacitance
Copy link
Author

@blown-capacitance Please help confirm that #14959 resolves this.

@filterpaper looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add MAGIC_TOGGLE_GUI line to main keycode documentation filterpaper/qmk_firmware
2 participants
@filterpaper @blown-capacitance