From 5b34967e9e5797a12422c7153e66d824b92ea60a Mon Sep 17 00:00:00 2001 From: Foysal Iqbal Date: Tue, 2 Jun 2020 12:25:26 -0400 Subject: [PATCH 1/3] fetch latest Signed-off-by: Foysal Iqbal --- pkg/qliksense/fetch.go | 6 +----- pkg/qliksense/get_installable_versions_test.go | 4 ++-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/pkg/qliksense/fetch.go b/pkg/qliksense/fetch.go index b44f7fea..b8fd26b3 100644 --- a/pkg/qliksense/fetch.go +++ b/pkg/qliksense/fetch.go @@ -2,7 +2,6 @@ package qliksense import ( "bufio" - "errors" "fmt" "io/ioutil" "os" @@ -54,10 +53,7 @@ func (q *Qliksense) FetchK8sWithOpts(opts *FetchCommandOptions) error { cr.SetFetchUrl(opts.GitUrl) } v := getVersion(opts, cr) - if v == "" { - return errors.New("Cannot find gitref/tag/branch/version to fetch") - } - if qConfig.IsRepoExistForCurrent(v) { + if v != "" && qConfig.IsRepoExistForCurrent(v) { if opts.Overwrite || getVerionsOverwriteConfirmation(v) == "y" { if err := qConfig.DeleteRepoForCurrent(v); err != nil { return err diff --git a/pkg/qliksense/get_installable_versions_test.go b/pkg/qliksense/get_installable_versions_test.go index 867cd2e4..00eef751 100644 --- a/pkg/qliksense/get_installable_versions_test.go +++ b/pkg/qliksense/get_installable_versions_test.go @@ -17,9 +17,9 @@ func TestGetLatestTag(t *testing.T) { t.Log(err) t.Log(sv) } - baseV, _ := semver.NewVersion("v0.0.7") + baseV, _ := semver.NewVersion("v0.0.8") if !sv.GreaterThan(baseV) { - t.Log("Expected greater than v0.0.7, but got: " + s) + t.Log("Expected greater than v0.0.8, but got: " + s) t.Fail() } } From 474638be65b32ffbaeac2463cbbb17392ceb1fca Mon Sep 17 00:00:00 2001 From: Foysal Iqbal Date: Tue, 2 Jun 2020 12:46:41 -0400 Subject: [PATCH 2/3] fetch latest Signed-off-by: Foysal Iqbal --- pkg/qliksense/get_installable_versions.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/qliksense/get_installable_versions.go b/pkg/qliksense/get_installable_versions.go index cce84afb..c3cb73d4 100644 --- a/pkg/qliksense/get_installable_versions.go +++ b/pkg/qliksense/get_installable_versions.go @@ -144,7 +144,7 @@ func getLatestTag(repoUrl, accessToken string) (string, error) { v, err := semver.NewVersion(sv) if err != nil { // it may happen, in the repo some tags may not conform to semver - fmt.Print("Unconform tags: " + sv) + fmt.Println("the tag is not conform to semver: " + sv) continue } if maxSem == nil || maxSem.LessThan(v) { From 8f7dab396c6d6078352751a79c3bce297697a624 Mon Sep 17 00:00:00 2001 From: Foysal Iqbal Date: Tue, 2 Jun 2020 13:07:04 -0400 Subject: [PATCH 3/3] fetch latest Signed-off-by: Foysal Iqbal --- pkg/qliksense/get_installable_versions.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/qliksense/get_installable_versions.go b/pkg/qliksense/get_installable_versions.go index c3cb73d4..85197a96 100644 --- a/pkg/qliksense/get_installable_versions.go +++ b/pkg/qliksense/get_installable_versions.go @@ -144,7 +144,7 @@ func getLatestTag(repoUrl, accessToken string) (string, error) { v, err := semver.NewVersion(sv) if err != nil { // it may happen, in the repo some tags may not conform to semver - fmt.Println("the tag is not conform to semver: " + sv) + //fmt.Println("the tag is not conform to semver: " + sv) continue } if maxSem == nil || maxSem.LessThan(v) {