File downloader alg can create a file with duplicated extension

[nicogodet]

What is the bug or the crash?

Téléchargement de https://storage.sbg.cloud.ovh.net/v1/AUTH_63234f509d6048bca3c9fd7928720ca1/ppk-lidar/IQ/LHD_FXX_0558_6277_PTS_C_LAMB93_IGN69.copc.laz réussi
Résultats: {'OUTPUT': 'C:/Users/godet/AppData/Local/Temp/processing_bFuZpI/LHD_FXX_0558_6277_PTS_C_LAMB93_IGN69.copc.laz.laz'}

See duplicated .laz extension

Steps to reproduce the issue

from pathlib import Path

import processing
from qgis.core import (
    QgsProcessingUtils,
)

tempDir = Path(QgsProcessingUtils.tempFolder())
filename = "LHD_FXX_0558_6277_PTS_C_LAMB93_IGN69.copc.laz"
url = "https://storage.sbg.cloud.ovh.net/v1/AUTH_63234f509d6048bca3c9fd7928720ca1/ppk-lidar/IQ/LHD_FXX_0558_6277_PTS_C_LAMB93_IGN69.copc.laz"

tempFile = tempDir / filename 


alg_param = {
    "URL": url,
    "METHOD": 0,
    "DATA": "",
    "OUTPUT": tempFile.as_posix(),
}

out = processing.run(
    "native:filedownloader",
    alg_param,
)
print(out["OUTPUT"])

See result

Versions

3.40.3

Supported QGIS version

• I'm running a supported QGIS version according to the roadmap.

New profile

• I tried with a new QGIS profile

Additional context

Faulty line:

QGIS/src/analysis/processing/qgsalgorithmfiledownloader.cpp

Line 144 in 15f06f1

if ( outputFile.startsWith( QgsProcessingUtils::tempFolder( &context ) ) )

it should instead check if output == QgsProcessing::TEMPORARY_OUTPUT

[nicogodet]

Is this change valid ?

if ( parameters.value( QStringLiteral( "OUTPUT" ) ) == QgsProcessing::TEMPORARY_OUTPUT )