Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature mitiff palette #947

Merged
merged 8 commits into from
Nov 4, 2019
Merged

Conversation

TAlonglong
Copy link
Collaborator

@TAlonglong TAlonglong commented Oct 21, 2019

This PR adds the possibility to write mitiff palette images

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@mraspaud mraspaud added component:writers enhancement code enhancements, features, improvements labels Oct 21, 2019
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #947 into master will increase coverage by 0.03%.
The diff coverage is 97.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #947      +/-   ##
==========================================
+ Coverage   86.61%   86.64%   +0.03%     
==========================================
  Files         175      175              
  Lines       26837    26925      +88     
==========================================
+ Hits        23244    23330      +86     
- Misses       3593     3595       +2
Impacted Files Coverage Δ
satpy/tests/writer_tests/test_mitiff.py 98.24% <100%> (+0.33%) ⬆️
satpy/writers/mitiff.py 91.64% <94.73%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d1c6a...a2375bc. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 86.647% when pulling d26a1b3 on TAlonglong:feature-mitiff-palette into 42d1c6a on pytroll:master.

@coveralls
Copy link

coveralls commented Nov 1, 2019

Coverage Status

Coverage increased (+0.02%) to 86.633% when pulling a2375bc on TAlonglong:feature-mitiff-palette into 42d1c6a on pytroll:master.

@TAlonglong TAlonglong closed this Nov 1, 2019
@TAlonglong TAlonglong reopened this Nov 1, 2019
@TAlonglong TAlonglong marked this pull request as ready for review November 1, 2019 13:49
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the format, but from what I understand it LGTM. Nice with the small refactoring also.

@mraspaud mraspaud merged commit 9710d32 into pytroll:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:writers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants