-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the olci l2 mask a bool array instead of floats #923
Conversation
@JohannesSMHI you might want to take a look at this. |
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
==========================================
+ Coverage 85.35% 85.36% +0.01%
==========================================
Files 174 174
Lines 26037 26053 +16
==========================================
+ Hits 22223 22240 +17
+ Misses 3814 3813 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing seems unreasonable here. A little confused by how this format is structured, but the code makes sense.
Is % 2
equivalent to & 0b11
?
Edit: Or maybe 0b01
?
yes it's equivalent, haven't checked the performance though. |
flake8 satpy