Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add altitude, landcover, and landseamask to mersi_ll_l1b reader #2953

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

chorng
Copy link
Contributor

@chorng chorng commented Oct 24, 2024

Add Altitude, LandCover, and LandSeaMask bands to mersi_ll_l1b reader for FY3E

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @simonrp84 thoughts?

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Oct 24, 2024
@djhoese djhoese self-assigned this Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (f36a096) to head (392267f).
Report is 279 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2953   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         377      377           
  Lines       55125    55125           
=======================================
  Hits        52967    52967           
  Misses       2158     2158           
Flag Coverage Δ
behaviourtests 3.94% <ø> (ø)
unittests 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Oct 24, 2024

Pull Request Test Coverage Report for Build 11662290144

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.191%

Totals Coverage Status
Change from base Build 11634318306: 0.0%
Covered Lines: 53211
Relevant Lines: 55318

💛 - Coveralls

@mraspaud mraspaud requested a review from simonrp84 October 25, 2024 11:33
@chorng
Copy link
Contributor Author

chorng commented Nov 4, 2024

Fixed conflict

@djhoese
Copy link
Member

djhoese commented Nov 4, 2024

This looks good enough to me. If @simonrp84 has comments after the fact then we can adjust things then in a new PR. Merging now. Thanks @chorng!

@djhoese djhoese merged commit 7e24c97 into pytroll:main Nov 4, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Altitude, LandCover, and LandSeaMask are missing in the mersi_ll_l1b reader for FY3E L1B
4 participants