-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid accidental NWCSAF-GEO type promotion #2874
Avoid accidental NWCSAF-GEO type promotion #2874
Conversation
Added a test to make sure that cloud type (or others) are not accidentally transformed to an inflated dtype. This currently fails with numpy 2.0; see pytroll#2872
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2874 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 368 368
Lines 53973 53982 +9
=======================================
+ Hits 51801 51810 +9
Misses 2172 2172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Make sure that integer dtypes when reading NWCSAF GEO are not accidentally cast to int64.
Oops 1: with this pull request, loading and computing Oops 2: this appears to be not caught by any tests. |
Nevermind then, I don't approve 😉 |
Pull Request Test Coverage Report for Build 10269258953Details
💛 - Coveralls |
The ValueError is due to a numpy2-incompatibility in trollimage: https://github.com/pytroll/trollimage/blob/main/trollimage/colormap.py#L182
numpy 1.24: numpy 2.0: |
Fixed with pytroll/trollimage#176. |
Avoid accidentally promoting the type in the NWCSAF GEO reader.
WARNING: Needs pytroll/trollimage#176 !