Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include gradient/axisintercept for mode p #2870

Merged

Merge branch 'main' into feature-ninjogeotiff-p-mode-gradient

ea7d8d2
Select commit
Loading
Failed to load commit list.
Merged

Include gradient/axisintercept for mode p #2870

Merge branch 'main' into feature-ninjogeotiff-p-mode-gradient
ea7d8d2
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Aug 23, 2024 in 38s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.01 (8.08 -> 8.09)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Large Method ninjogeotiff.py: NinJoGeoTIFFWriter.save_image

Annotations

Check notice on line 1 in satpy/tests/writer_tests/test_ninjogeotiff.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File

The lines of code increases from 750 to 754, improve code health by reducing it to 600. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 209 in satpy/writers/ninjogeotiff.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Large Method

NinJoGeoTIFFWriter.save_image decreases from 92 to 90 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.