Include gradient/axisintercept for mode p #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NinJo wants that gradient=1 and axisintercept=0 for images of mode p. It shall be so.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2870 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 370 370
Lines 54320 54332 +12
=======================================
+ Hits 52177 52189 +12
Misses 2143 2143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 10528439571Details
💛 - Coveralls |
…iff-p-mode-gradient
In the ninjogeotiff writer, when testing p-mode images, add an enhancement history such as palettize would add, to get a more realistic test.
For ninjogeotiff mode p, force scale/offset to be 1 and 0, respectively. As a workaround for pytroll#2300, do not check image.mode, but use image.data.attrs["mode"] instead.
The fallback/workaround to use image.data.attrs["mode"] instead of image.mode can and should only be used after to_image has been called. Before to_image has been called, the former is unavailable and the latter is reliable, I think.
b675cbf to
2440dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NinJo expects palette images to include gradient and axisintercept with values 1 and 0, respectively.
Needs #2874 to be merged first.
I needed to include some workarounds for #2300.
AUTHORS.mdif not there already