Fix FCI L1c reader for African products #2866
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.10 (9.42 -> 9.32)
-
Declining Code Health: 1 findings(s) 🚩
-
Affected Hotspots: 1 files(s) 🔥
Details
🚩 Declining Code Health (highest to lowest):
- Bumpy Road Ahead test_fci_l1c_nc.py: fill_chans_af 🔥
Annotations
Check notice on line 1 in satpy/tests/reader_tests/test_fci_l1c_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 627 to 632, improve code health by reducing it to 600. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 215 in satpy/tests/reader_tests/test_fci_l1c_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
fill_chans_af has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1096 in satpy/tests/reader_tests/test_fci_l1c_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Excess Number of Function Arguments
TestFCIL1cNCReader.test_count_in_repeat_cycle_rc_period_min_AF has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.