Add MERSI3 / FY3F support. #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
==========================================
- Coverage 95.95% 95.95% -0.01%
==========================================
Files 366 366
Lines 53617 53615 -2
==========================================
- Hits 51448 51446 -2
Misses 2169 2169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
You forgot to change the filetype name from mersi2 to mersi3... |
Haha, well spotted - fixed now. Thanks @yukaribbba! |
Pull Request Test Coverage Report for Build 10002879545Details
💛 - Coveralls |
mraspaud
approved these changes
Jul 19, 2024
|
Ah, I see it is ready, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the MERSI-3 instrument aboard FY-3F. There's no code changes required, as the existing MERSI-2 code can be used, so only new YAML files are added.