Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DayNightCompositor compatibility with numpy 2 #2835

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jun 22, 2024

Requires pytroll/pyorbital#155 to be fully fixed as far as the DayNightCompositor goes. I mentioned it on slack, but basically np.some_func(float) with numpy 2 will always produce a numpy.float64. Any future calculations with that result will then upcast/promote to numpy.float64 even if there are 32-bit float arrays.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (816426e) to head (9339a7f).
Report is 341 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2835      +/-   ##
==========================================
+ Coverage   95.77%   95.94%   +0.16%     
==========================================
  Files         366      366              
  Lines       53501    53543      +42     
==========================================
+ Hits        51243    51371     +128     
+ Misses       2258     2172      -86     
Flag Coverage Δ
behaviourtests 4.04% <0.00%> (+<0.01%) ⬆️
unittests 96.04% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djhoese djhoese force-pushed the bugfix-np2-compat branch from 464f6b3 to 609d894 Compare June 26, 2024 02:35
@djhoese djhoese merged commit 29ad90f into pytroll:main Jun 26, 2024
18 of 19 checks passed
@djhoese djhoese deleted the bugfix-np2-compat branch June 26, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant