Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the vii_l1b-reader, for new testdata format of VII #2807

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

shornqui
Copy link

@shornqui shornqui commented May 31, 2024

EUMETSAT has updated the EPS-SG testdata for VII (METimage), to version 2.1. There is one variable in the netCDF-file that has changed names. Because of that the VII-level1b-reader needs to be update.
(I have also checked with EUMETSAT, this change is meant to stay -the old variable name was a bug.)

There were no need to add new tests, but there was an updated test, due to this change.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@shornqui shornqui marked this pull request as ready for review May 31, 2024 13:48
@shornqui shornqui requested review from djhoese and mraspaud as code owners May 31, 2024 13:48
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (3b9c04e) to head (c698e31).
Report is 500 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2807      +/-   ##
==========================================
- Coverage   95.95%   95.93%   -0.03%     
==========================================
  Files         379      366      -13     
  Lines       53888    53528     -360     
==========================================
- Hits        51708    51351     -357     
+ Misses       2180     2177       -3     
Flag Coverage Δ
behaviourtests 4.04% <0.00%> (-0.05%) ⬇️
unittests 96.03% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9318985608

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.032%

Totals Coverage Status
Change from base Build 9157044280: 0.0%
Covered Lines: 51580
Relevant Lines: 53711

💛 - Coveralls

@mraspaud mraspaud merged commit c83b964 into pytroll:main Jun 3, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants