Fix some enhancements producing dask arrays wrapped in dask arrays #2190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while counting the number of dask computations that some enhancements were causing more computations than they used to. This was caused by some of the dask arrays producing dask arrays so the dask arrays were being passed to rasterio during geotiff saving which caused yet another compute.
The issue was that due to the refactoring in #2133, the functions were accidentally doing dask "stuff" (delayed functions or
da.where
) inside a function that was already map_blocks'd. This PR fixes all of that and adds checks to the tests to make sure it hopefully doesn't happen again in the future.