-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to define the dataset rectification longitude in seviri_l2_bufr reader #2078
Add possibility to define the dataset rectification longitude in seviri_l2_bufr reader #2078
Conversation
…add_rectification_longitude_to_seviri_l2_bufr_reader
…add_rectification_longitude_to_seviri_l2_bufr_reader
Codecov Report
@@ Coverage Diff @@
## main #2078 +/- ##
=======================================
Coverage 93.79% 93.80%
=======================================
Files 283 283
Lines 42284 42295 +11
=======================================
+ Hits 39662 39673 +11
Misses 2622 2622
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The SEVIRI L2 BUFR data are originally been extracted from a rectified two-dimensional SEVIRI grid with a given central longitude (typically the sub-satellite point). Previously this longitude was hard-coded for each SEVIRI instrument (Meteosat satellite) in the reader, following the current operational grids. This is sub-optimal when working with e.g. historic data where the operational grid for a given instrument is different, as this will lead to an incorrect
AreaDefinition
in case the data are returned with one (with_area_definition=True
). Since the information about the satellite position or original grid rectification longitude is not available in the file itself or the filename (for files from the EUMETSAT archive) and cannot be reliably derived from all datasets themselves, this PR adds the possibility to provide this information as areader_kwarg
(rectification_longitude
) when initializing theScene
object for theseviri_l2_bufr
reader.If this
reader_kwarg
is not provided, the default longitude defined for a given satellite/instrument will be used (unless the information can be extracted from the filename (internal EUMETSAT files)) thus following the previous implementation.The PR also modifies the default SSP_LON for Meteosat-9 in preparation for it's upcoming relocation to the IODC service at 45.5 degrees east.