-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example to the documentation using multiple readers #2071
Add example to the documentation using multiple readers #2071
Conversation
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
I thought RTD pages should be build for the PR, so I could check it? Wasn't that the case previously? Or am I thinking of the Pyspectral repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few typographic corrections.
Fix typographic error Co-authored-by: Gerrit Holl <gerrit.holl@gmail.com>
Fix typo Co-authored-by: Gerrit Holl <gerrit.holl@gmail.com>
Fix typo Co-authored-by: Gerrit Holl <gerrit.holl@gmail.com>
Thanks @gerritholl ! That was sloppy of me, good you saw it. |
I think you said this last time @adybbroe 😉 I don't remember RTD's current preferred way of requesting PRs to be built is. We do have a CI job that builds the docs which is at least a first step in catching errors. I don't remember if I made it make an "artifact" in the CI so that you can download the site and see the results. That of course could/should be replaced by RTD generation if it doesn't cost us anything. |
…se comes last Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
satpy/scene.py
Outdated
``filenames`` needs to be a `dict` (see parameters list below), like | ||
e.g.:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The like
might be redundant or unnecessary here. It reads a little funny.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for making the changes.
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Just giving an example of providing a dataset that requires multiple readers.
It was quite clear from the documentation already, but thought it was nice giving an explicit example, as at least I have been in doubt a couple of times how to do it correct.
AUTHORS.md
if not there already