-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dataset attribute typo and reduce amount of categorical dataset filtering in fci_l2_nc reader #2049
Conversation
…e typo that was added to the reader.
Codecov Report
@@ Coverage Diff @@
## main #2049 +/- ##
==========================================
+ Coverage 93.73% 93.77% +0.03%
==========================================
Files 282 282
Lines 42080 42092 +12
==========================================
+ Hits 39444 39472 +28
+ Misses 2636 2620 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this, just remove the FIXME tag (you can leave the comment though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can we get an updated title for this PR that describes what was done/fixed so it can be used in release notes? |
Fixed. Please note that this was a bugfix for a PR merged just a couple of days ago, so it's not a bugfix wrt. the previous release. |
Ok thanks for the clarification and the title change. Even if it is just a fix for a previous PR it still shows up in the changelog so nice to have something descriptive. |
This PR fixes two minor bugs introduced with the recent merge of PR1927.
inverse_flattening
, the reader did not work properly. A temporary workaround has been implemented for the time being until the L2PF test files are correctly formatted.