-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak in cached_property backport #2011
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2011 +/- ##
==========================================
- Coverage 93.56% 93.55% -0.02%
==========================================
Files 281 282 +1
Lines 41480 41538 +58
==========================================
+ Hits 38811 38860 +49
- Misses 2669 2678 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Where does this solution come from? Stackoverflow? Official CPython docs somewhere? |
If you update line 267 in
it should fix the build_website failure. Numpy updated their documentation structure. |
It was an stackoverflow answer that pointed me to the CPython repository: https://stackoverflow.com/a/58592597/5703449 |
Done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. It is a much more involved solution than I thought it was going to be. I think given that we are removing Python 3.7 support I think we should merge this, make a release, then immediately remove this as part of a PR to drop Python 3.7 support. Thoughts @sfinkens @mraspaud @pnuu ?
Oops @gerritholl you too, thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a patch for the last release supporting python 3.7 :)
Closes #2008 by replacing the existing backport with the
cached_property
implementation from the Python-3.8 repository.