Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read the "elevation" variable in slstr_l1b #1989

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

ghislainp
Copy link
Contributor

The slstr_l1b drivers now can read the "elevation" variable along with latitude and longitude in the geodetic files.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • [ X] Add your name to AUTHORS.md if not there already

@ghislainp ghislainp requested a review from mraspaud as a code owner January 23, 2022 21:17
@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #1989 (6eb2936) into main (15f727b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1989   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         279      279           
  Lines       41322    41322           
=======================================
  Hits        38654    38654           
  Misses       2668     2668           
Flag Coverage Δ
behaviourtests 4.78% <ø> (ø)
unittests 94.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f727b...6eb2936. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.005% when pulling 6eb2936 on ghislainp:master into 15f727b on pytroll:main.

@djhoese djhoese added component:readers enhancement code enhancements, features, improvements labels Jan 24, 2022
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding the elevation :) LGTM

@mraspaud mraspaud merged commit 751d555 into pytroll:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants