-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix angle generation not working for StackedAreaDefinitions #1946
Conversation
@mraspaud I could/should update the configuration documentation about how SwathDefinitions and StackedAreaDefinitions are not cache-able, but maybe StackedAreaDefinition could be updated in pyresample to combine the hashes of its sub-areas to generate its own hash? |
Oh maybe that is already done. Let me check. |
Done. Fixed it so StackedAreaDefinitions can be hashed and cached in the angle generation. |
Codecov Report
@@ Coverage Diff @@
## main #1946 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 279 279
Lines 41276 41317 +41
=======================================
+ Hits 38606 38647 +41
Misses 2670 2670
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor styling comment. Thanks for taking the time to clean up a bit also!
Another think (that doesn't need to be adressed in this PR): could _hash_args
be replaces with dask's tokenize
? otherwise I'm wondering if a try/except would be more future-proof than the series of isinstance
checks.
Regarding Regarding a |
The optional caching functionality of the angle generation does not work for geometry types that can't be serialized. This logic was able to serialize StackedAreaDefinitions but was only looking for AreaDefinitions. This PR makes it so StackedAreaDefinitions are also cache-able.