Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AHI gridded reader to use HTTP instead of FTP #1897

Merged
merged 5 commits into from
Nov 25, 2021

Conversation

simonrp84
Copy link
Member

The AHI gridded reader currently uses FTP to downlod the required look up tables. This PR switches to HTTP.

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #1897 (bb4b2fe) into main (ef301b0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1897   +/-   ##
=======================================
  Coverage   93.29%   93.30%           
=======================================
  Files         273      273           
  Lines       40460    40464    +4     
=======================================
+ Hits        37748    37754    +6     
+ Misses       2712     2710    -2     
Flag Coverage Δ
behaviourtests 4.71% <0.00%> (-0.01%) ⬇️
unittests 93.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/ahi_l1b_gridded_bin.py 100.00% <100.00%> (+0.94%) ⬆️
...tpy/tests/reader_tests/test_ahi_l1b_gridded_bin.py 100.00% <100.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef301b0...bb4b2fe. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 25, 2021

Coverage Status

Coverage increased (+0.006%) to 93.788% when pulling bb4b2fe on simonrp84:ahi_grid_fix into ef301b0 on pytroll:main.

Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Nov 25, 2021
@mraspaud mraspaud merged commit 5bb4f63 into pytroll:main Nov 25, 2021
@simonrp84 simonrp84 deleted the ahi_grid_fix branch November 25, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants