Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'seadas_l2' reader for 'chlor_a' product #1894

Merged
merged 6 commits into from
Nov 29, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 22, 2021

Attempt at reading some files that came across my desk that are created by SEADAS and are created from either MODIS or VIIRS data.

  • Tests added
  • Fully documented

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Nov 22, 2021
@djhoese djhoese self-assigned this Nov 22, 2021
@djhoese
Copy link
Member Author

djhoese commented Nov 22, 2021

Last thing I need to do is finalize the enhancement.

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #1894 (5a240be) into main (ef301b0) will increase coverage by 0.09%.
The diff coverage is 98.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1894      +/-   ##
==========================================
+ Coverage   93.29%   93.38%   +0.09%     
==========================================
  Files         273      275       +2     
  Lines       40460    40732     +272     
==========================================
+ Hits        37748    38039     +291     
+ Misses       2712     2693      -19     
Flag Coverage Δ
behaviourtests 4.81% <0.00%> (+0.09%) ⬆️
unittests 93.95% <98.18%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/seadas_l2.py 97.82% <97.82%> (ø)
satpy/tests/reader_tests/test_seadas_l2.py 98.43% <98.43%> (ø)
satpy/tests/reader_tests/test_vii_l2_nc.py 93.93% <0.00%> (-6.07%) ⬇️
satpy/tests/reader_tests/test_vii_l1b_nc.py 97.18% <0.00%> (-2.82%) ⬇️
satpy/tests/reader_tests/test_nwcsaf_msg.py 96.63% <0.00%> (-1.69%) ⬇️
satpy/readers/li_l2.py 11.66% <0.00%> (-1.67%) ⬇️
satpy/tests/test_config.py 93.84% <0.00%> (-0.77%) ⬇️
satpy/resample.py 80.03% <0.00%> (-0.25%) ⬇️
satpy/readers/seviri_l1b_nc.py 67.29% <0.00%> (-0.21%) ⬇️
satpy/readers/ghrsst_l3c_sst.py 7.04% <0.00%> (-0.21%) ⬇️
... and 206 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef301b0...5a240be. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 22, 2021

Coverage Status

Coverage increased (+0.1%) to 93.905% when pulling 5a240be on djhoese:feature-seadas-l2 into ef301b0 on pytroll:main.

@djhoese djhoese marked this pull request as ready for review November 29, 2021 19:12
@djhoese djhoese requested a review from mraspaud as a code owner November 29, 2021 19:12
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small suggestion

Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
@djhoese djhoese merged commit fdedbe2 into pytroll:main Nov 29, 2021
@djhoese djhoese deleted the feature-seadas-l2 branch November 29, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants