Fix for missing attributes when requesting 'counts' calibration from ABI L1B reader. #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of Pull Request pytroll#1692, we added an early return to abi_l1b.py's get_dataset method when the requested calibration is "counts". The problem is that the early return results in a number of missing attributes in the object returned from get_dataset. I also took the liberty of updating the unit tests to check for some of the missing attributes, as well as including a test for invalid calibration.
Should satisfy the pull request requirements.
djhoese
reviewed
Aug 23, 2021
Also adjusted the formatting of test_abi_l1b.py so that it'll conform with flake8 (and flake8-docstring).
djhoese
approved these changes
Aug 24, 2021
Codecov Report
@@ Coverage Diff @@
## main #1800 +/- ##
=======================================
Coverage 92.92% 92.92%
=======================================
Files 265 265
Lines 39081 39092 +11
=======================================
+ Hits 36316 36328 +12
+ Misses 2765 2764 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thanks @jon4than! |
simonrp84
pushed a commit
to simonrp84/satpy
that referenced
this pull request
Nov 24, 2021
…ABI L1B reader. (pytroll#1800) * Fix ABI L1B reader not returning expected attrs. As part of Pull Request pytroll#1692, we added an early return to abi_l1b.py's get_dataset method when the requested calibration is "counts". The problem is that the early return results in a number of missing attributes in the object returned from get_dataset. I also took the liberty of updating the unit tests to check for some of the missing attributes, as well as including a test for invalid calibration. * Add myself to AUTHORS.md. Should satisfy the pull request requirements. * Add explicit copy() of raw counts Also adjusted the formatting of test_abi_l1b.py so that it'll conform with flake8 (and flake8-docstring).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of Pull Request #1692, we added an early return to abi_l1b.py's get_dataset method when the requested calibration is "counts".
The problem is that the early return results in a number of missing attributes in the object returned from get_dataset.
I also took the liberty of updating the unit tests to check for some of the missing attributes, as well as including a test for invalid calibration.
As an aside, I agree with the logic for why it was decided to return early; the
self.nc['Rad']values aren't radiances. That said, I couldn't think of a more straightforward way to write this code.AUTHORS.mdif not there already